[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

Anshil Gandhi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 2 16:01:08 PDT 2021


gandhi21299 added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:597
+      OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction());
+      Remark << "A hardware instruction was generated";
+      return Remark;
----------------
arsenm wrote:
> This is too strong of a statement here, although I think emitting anything here is useless
The only other option is SIISelLowering then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891



More information about the cfe-commits mailing list