[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A
Stanislav Mekhanoshin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 2 15:36:39 PDT 2021
rampitec added a comment.
In D106891#2921048 <https://reviews.llvm.org/D106891#2921048>, @gandhi21299 wrote:
> @rampitec should the unsafe check go in some pass later in the pipeline then?
No. The only place which has all the knowledge is `SITargetLowering::shouldExpandAtomicRMWInIR()`. That is where diagnostics shall be emitted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
More information about the cfe-commits
mailing list