[PATCH] D107292: [clang] adds warning to alert user when they use alternative tokens as references
Christopher Di Bella via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 2 13:33:36 PDT 2021
cjdb added a subscriber: eric_niebler.
cjdb added a comment.
In D107292#2920774 <https://reviews.llvm.org/D107292#2920774>, @dblaikie wrote:
> In D107292#2920746 <https://reviews.llvm.org/D107292#2920746>, @cjdb wrote:
>
>> In D107292#2920637 <https://reviews.llvm.org/D107292#2920637>, @dblaikie wrote:
>>
>>> Not a huge objection - but minor quandry: What's the motivation for this patch? I don't know of any codebase that encourages/uses the alternative tokens and I wonder if adding more usability to them is a worthwhile investment in clang's codebase complexity, etc.
>>
>> There are codebases that use them (all of my non-Google, non-LLVM code does, for example, and I'm not the sole user: just a loud one who's also in a position to patch tooling).
>
> Ah, any pointers to large open source projects that use this?
Large OSS? No, sorry. range-v3 //used// to use them, but it was having issues integrating with Folly (I think) and @eric_niebler had to abandon using them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107292/new/
https://reviews.llvm.org/D107292
More information about the cfe-commits
mailing list