[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 2 01:08:19 PDT 2021


hans added a comment.

In D74436#2917395 <https://reviews.llvm.org/D74436#2917395>, @mibintc wrote:

> In D74436#2917357 <https://reviews.llvm.org/D74436#2917357>, @haowei wrote:
>
>> We are seeing float related unit tests failing in Fuchsia after this patch. What flags should we add to our build to match llvm's previous float point behavior?
>
> This option: ffp-contract=off

We're seeing float related tests fail in Chromium too (crbug.com/1235145). I haven't read the background llvm-dev thread about this, but is changing the default behavior here really intentional? Does it match what the standards require and what other compilers do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74436/new/

https://reviews.llvm.org/D74436



More information about the cfe-commits mailing list