[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 1 13:10:50 PDT 2021


mstorsjo added a subscriber: tstellar.
mstorsjo added a comment.

In D107231#2918835 <https://reviews.llvm.org/D107231#2918835>, @v.g.vassilev wrote:

> In D107231#2918834 <https://reviews.llvm.org/D107231#2918834>, @mstorsjo wrote:
>
>> In D107231#2918824 <https://reviews.llvm.org/D107231#2918824>, @v.g.vassilev wrote:
>>
>>> Forgot to mention that we may need to backport this patch to the llvm13 branch.
>>
>> That might be good yes, especially if you intend to enable it by default there too. (I only noticed this after it was enabled by default).
>
> It should be enabled already for the llvm13 branch.

Oh, I had missed that this was changed right before the branch (I did my last similar test build a couple days before the branch). Yes then it indeed needs to be backported. @tstellar ok to backport?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107231/new/

https://reviews.llvm.org/D107231



More information about the cfe-commits mailing list