[PATCH] D106349: [clang-format] respect AfterEnum for enums

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 31 08:02:10 PDT 2021


HazardyKnusperkeks added a comment.

In D106349#2914448 <https://reviews.llvm.org/D106349#2914448>, @m1cha wrote:

> I don't have commit access. How does that even work? The documentation is very scarce about this but for security reasons I'd expect there to be a very limited set of people with commit access
>
> Here's my author info:
> `Michael Zimmermann <sigmaepsilon92 at gmail.com>`

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access I don't think it is limited, I'm also //just some guy// which applied for it some 7 months ago. Since the next release is far away, you can apply for the access and commit it yourself. I did only wait one day. ;)

In D106349#2914500 <https://reviews.llvm.org/D106349#2914500>, @lunasorcery wrote:

> Note also there's significant overlap with the now-committed D99840 <https://reviews.llvm.org/D99840>, though that's missing the change inside ShouldBreakBeforeBrace().
> In retrospect I'm a little confused as to why D99840 <https://reviews.llvm.org/D99840> appears to work without it.

I thought it looked familiar, but did not find what it was. Does this change needs to be rebased before it can be applied?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106349/new/

https://reviews.llvm.org/D106349



More information about the cfe-commits mailing list