[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 12:34:40 PDT 2021


dexonsmith added a comment.

In D107155#2916664 <https://reviews.llvm.org/D107155#2916664>, @dblaikie wrote:

> Hmm, don't we have some other substitution feature that avoids the need to add the %? (like, I think LLVM's tests don't usually use the % for many tool names - but they still make for good copy/pastable command lines, if I'm not mistaken?)

I think that'd be adding clang-scan-deps somehow to the `tools` variable in clang/test/lit.cfg.py:
 https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py#L59
(which will then call `add_tool_substitutions` at https://github.com/llvm/llvm-project/blob/main/clang/test/lit.cfg.py#L111)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107155/new/

https://reviews.llvm.org/D107155



More information about the cfe-commits mailing list