[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 12:28:39 PDT 2021


v.g.vassilev added inline comments.


================
Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64
+// address of main, and some platforms can't implement GetMainExecutable
+// without being given the address of a function in the main executable).
+std::string GetExecutablePath(const char *Argv0, void *MainAddr) {
----------------
rsmith wrote:
> I don't follow why this can't be static. Is there some problem with using the address of this function if it's static?
That's a standard comment for each `GetExecutablePath` and I copy pasted it as done elsewhere. That requirement might be lifted in recent systems but I do not know the platform coverage to check.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107049/new/

https://reviews.llvm.org/D107049



More information about the cfe-commits mailing list