[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 10:45:19 PDT 2021


NoQ added a comment.

In D105821#2914082 <https://reviews.llvm.org/D105821#2914082>, @RedDocMD wrote:

> On running this patch on the `projects` directory, a bunch of projects emit false-positives: mostly of the form `Potential memory leak`. This points to the fact that without calling the destructor of the pointee type, we are going to have a lot of false positives (408 for //one// project is the worst I have seen). I have attached the result file.

Can you attach all or some of the newly found html reports?

Is this about invalidation in `~unique_ptr()` modeling being insufficient, or about us not doing anything at all with pointee on other occasions such as `.reset()` or might it be that the lack of invalidation for constructor inside `make_unique()` also plays its part?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105821/new/

https://reviews.llvm.org/D105821



More information about the cfe-commits mailing list