[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support
Jon Chesterfield via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 30 07:11:32 PDT 2021
JonChesterfield accepted this revision.
JonChesterfield added inline comments.
================
Comment at: clang/lib/Headers/openmp_wrappers/cmath:113
+__DEVICE__ float lgamma(float __x) { return ::lgammaf(__x); }
+//__DEVICE__ long long int llrint(float __x) { return ::llrintf(__x); }
+//__DEVICE__ long long int llround(float __x) { return ::llroundf(__x); }
----------------
let's not add in commented out code
================
Comment at: clang/test/Headers/Inputs/include/cstdlib:24
+// amdgcn already provides definition of fabs
float fabs(float __x) { return __builtin_fabs(__x); }
----------------
drop comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104904/new/
https://reviews.llvm.org/D104904
More information about the cfe-commits
mailing list