[PATCH] D106899: [Support] Remove LLVM_ATTRIBUTE_NORETURN
    Fangrui Song via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu Jul 29 10:15:12 PDT 2021
    
    
  
MaskRay added a comment.
In D106899#2913925 <https://reviews.llvm.org/D106899#2913925>, @gAlfonso-bit wrote:
> Still not passing (what is going on?)
If you click a harbomaster URI, sometimes the builds are good
  x64 debian passed
  x64 windows passed
and sometimes there may be failures apparently unrelated to your patch.
Some discretion is needed.
I ended up making the refactoring by myself. Your change included some whole-file clang-format formatting which wasn't suitable.
I usually run `git diff -U0 --no-color 'HEAD^' | clang/tools/clang-format/clang-format-diff.py -i -p1` to only format related lines.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106899/new/
https://reviews.llvm.org/D106899
    
    
More information about the cfe-commits
mailing list