[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev added a comment.

Makes sense, thank you for the explanation. I've changed the problematic doc but this is probably still fine. Honestly, I don't really think we should have more Unicode symbols in the docs for generators hence this patch might not be needed but I'd be OK if you really still want to land it. The "problem" is that we'd be left with somewhat non-uniformity (there are many other Python scripts with `open` and inputs there might also have similar issues) but I guess that's what we have anyway.



================
Comment at: clang-tools-extra/clang-tidy/add_new_check.py:19
 
+# The documentation files are encoded using UTF-8, however on Windows the
+# default encoding might be different (e.g. CP-1252). To make sure UTF-8 is
----------------
The comments look misplaced now. Maybe add it next to the first `io.open` and end with "Here and elsewhere"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106792/new/

https://reviews.llvm.org/D106792