[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

[Andy Yankovsky via Phabricator via cfe-commits]

werat added a comment.

> Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the open shadow is maybe not the best way to solve this (please feel free to let me know if there are reasons it would be better), maybe spell it out explicitly (there aren't that many cases of open)?

It seemed a bit tedious to spell it out explicitly everywhere, but you're right, not a script of this size it's not a problem. The benefit of a global shadow is that nobody will use regular `open` accidentally, but I think the risk of that is relatively low.

> Also, hm... Do we really need these? It's safe to remove those, this shouldn't be a problem, I think.

I don't think using non-ASCII quotes was intentional and we can definitely remove them. But future-proofing this script will avoid this problem in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106792/new/

https://reviews.llvm.org/D106792