[PATCH] D107026: [Clang] Add support for attribute 'escape'

[Josh Learn via Phabricator via cfe-commits]

guitard0g marked an inline comment as done.
guitard0g added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:1952
 
+def Escape : Attr {
+  let Spellings = [Clang<"escape">];
----------------
NoQ wrote:
> Shouldn't both this attribute and the one above be `InheritableAttr`?
> 
> Comments in this file say:
> ```
> /// An inheritable attribute is inherited by later redeclarations.
> ```
> Which is arguably exactly what we want? Like, it should be sufficient to put the attribute into the header, there's no need to duplicate it in the implementation?
Oh! Good point, I totally agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107026/new/

https://reviews.llvm.org/D107026