[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

[Anjan Kumar via Phabricator via cfe-commits]

anjankgk marked an inline comment as done.
anjankgk added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:263
+      if (!T.isOSAIX()) {
+        TC.getDriver().Diag(diag::err_drv_unsupported_opt)
+            << A.getAsString(Args);
----------------
ZarkoCA wrote:
> anjankgk wrote:
> > ZarkoCA wrote:
> > > nit, I prefer this error message but it's up to you. 
> > I intentionally chose that error msg (without target mention) since that's the one the original option threw (existing '-b' option which was defined as unsupported for all the platforms).
> I see, that makes sense.
> 
> But now with your patch this option is supported even if only for the AIX target. So we could make the case to use the suggested error message. That said, I am still fine with what you choose. 
I actually agree on your point. So, eventhough my intention was to leave the behavior on other (non-AIX) platforms unaffected, the change causes the behavior of the option to be more target-specific - since it's now valid/supported option on AIX. So, I am going to change this error message as suggested. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106688/new/

https://reviews.llvm.org/D106688