[PATCH] D106899: [LLVM][NFC] Remove LLVM_ATTRIBUTE_NORETURN and use [[noreturn]] directly

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 28 09:39:36 PDT 2021


MaskRay added a comment.

I migrated all llvm/ files. You need to remove them from the patch.

It is a good idea to drop the macro definition in `llvm/include/llvm/Support/Compiler.h` separately.

It makes it easy to bring back the definition if some downstream users want extended time for migration. (Note: downstream is on their own. This is offering kindness, not an obligation of llvm-project.)
For example, swift is using `LLVM_ATTRIBUTE_NORETURN`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106899/new/

https://reviews.llvm.org/D106899



More information about the cfe-commits mailing list