[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 28 05:41:23 PDT 2021


kbobyrev added a comment.

Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the `open` shadow is maybe not the best way to solve this (please feel free to let me know if there are reasons it would be better), maybe spell it out explicitly (there aren't that many cases of `open`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106792/new/

https://reviews.llvm.org/D106792



More information about the cfe-commits mailing list