[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

[Whisperity via Phabricator via cfe-commits]

whisperity added inline comments.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156
+
+  ⁣Added support for initialization check of the scoped enum
+
----------------
whisperity wrote:
> Unterminated sequence. Also, where is this feature implemented?
@Sockke Sorry if I'm ultra dense here, but I still do not see what sort of support was added, or where. Do you mean that //scoped enums// were **never** reported before by this check, and that 5 lines of new code you added fixes that too? If that is the case, I'd rather rephrase the sentence here. I think `FixIt` is also an internal term (at least when written as such), `clang-tidy --help` only says:

> --fix                - Apply suggested fixes.

Suggestion:

> Removed generating fixes for enums because the code generated was broken, trying to initialise the enum from an integer.

And if my understanding of what "support was added" is true, then also:

> The check now also warns for uninitialised scoped enums.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431