[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

[Ben Shi via Phabricator via cfe-commits]

benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430
 
+    CmdArgs.push_back("--end-group");
+
----------------
You are appreciated to use 'git show -U999999' or 'git diff -U999999' for better context display.


================
Comment at: clang/test/Driver/avr-ld.c:23
 // RUN: %clang -### --target=avr -mmcu=atmega328 --sysroot %S/Inputs/basic_avr_tree %s 2>&1 | FileCheck -check-prefix LINKH %s
-// LINKH: {{".*ld.*"}} {{.*}} {{"-L.*avr5"}} {{.*}} "-Tdata=0x800100" {{.*}} "-latmega328" "-mavr5"
+// LINKH: {{".*ld.*"}} {{.*}} {{"-L.*avr5"}} {{.*}} "-Tdata=0x800100" {{.*}} "-latmega328" {{.*}} "-mavr5"
 
----------------
could you add explict options (which you added) to these tests ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106854/new/

https://reviews.llvm.org/D106854