[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Tue Jul 27 17:12:02 PDT 2021

tstellar added a comment.

In D105527#2908944 <https://reviews.llvm.org/D105527#2908944>, @Bigcheese wrote:

> Also, this python script just doesn't work. It's missing a sys import, a "w" flag, and a new line after each write. It also dumps the output into the source directory. Was this actually tested?

I fixed all these issues in the main branch yesterday.

================
Comment at: clang/test/LibClang/symbols.test:2
+# Check that there are no unversioned clang symbols in libclang.so
+RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang'
+
----------------
thakis wrote:
> thakis wrote:
> > I think it's possible to configure the build to only build a static libclang. This should probably only be done if libclang is built dynamically?
> Aha, libclang.so doesn't exist then and then the config.pipefail=False makes things pass then. Subtle.
> Aha, libclang.so doesn't exist then and then the config.pipefail=False makes things pass then. Subtle.

This was not my intention, but I'm glad it works.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527