[PATCH] D106614: [Clang] add btf_tag attribute

[Yonghong Song via Phabricator via cfe-commits]

yonghong-song added inline comments.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:2019
+targets. This attribute may be attached to a struct/union, struct/union field,
+function or variables declaration. If -g is specified, the ARGUMENT info will
+be preserved in IR and be emitted to dwarf. For BPF target, the ARGUMENT info
----------------
anakryiko wrote:
> can it be also applied to function's argument?
The attribute does apply to function argument. I missed it in the documentation. Will add it.


================
Comment at: clang/test/Sema/attr-btf_tag.c:13
+
+int __tag foo(struct t1 __tag *arg) {
+  return arg->a;
----------------
anakryiko wrote:
> in this case, second __tag, does it apply to function argument, or pointer, or pointer's pointee (struct t1)?
apply to function argument. In dwarf, it applies to DW_TAG_member.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106614/new/

https://reviews.llvm.org/D106614