[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 27 12:19:34 PDT 2021


jsji added inline comments.


================
Comment at: clang/tools/libclang/CMakeLists.txt:79
+  set(LLVM_EXPORTED_SYMBOL_FILE)
+  set(USE_VERSION_SCRIPT TRUE)
+endif()
----------------
I think we should check LLVM_HAVE_LINK_VERSION_SCRIPT here, there are platforms that does NOT support VERSION_SCRIPT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527



More information about the cfe-commits mailing list