[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

[Justas Janickas via Phabricator via cfe-commits]

Topotuna added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:1964
 
+Address space removal
+---------------------
----------------
Anastasia wrote:
> Anastasia wrote:
> > Maybe we could title it something like:
> > 
> > `Address space removal utility`
> > or
> > `Address space removal trait`
> > ?
> Although we could also be more specific and name it
> `Remove address space builtin function`?
`Builtin address space removal utility`?

I would prefer not to leave wording "Remove address space" in description because it is already what utility name says and so it adds no extra information.


================
Comment at: clang/docs/LanguageExtensions.rst:1968
+``__remove_address_space`` allows to derive types in C++ for OpenCL
+that have address space qualifiers removed. The tool only throws away
+address space qualifiers, therefore, other type qualifiers such as
----------------
Anastasia wrote:
> 
I would rather use word "affects" instead of "removes" here. There is already excessive amount of "remove" in this paragraph


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106785/new/

https://reviews.llvm.org/D106785