[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

Brian Cain via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 26 21:59:02 PDT 2021


bcain added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604
+  const bool HasSysRoot = !D.SysRoot.empty();
+  if (HasSysRoot) {
     SmallString<128> P(D.SysRoot);
----------------
MaskRay wrote:
> To match Linux.cpp, this code block should be unconditional.
I *think* this is an intentional difference from `Linux.cpp` in order to suit `hexagon-unknown-elf`. @sidneym do you think we need this conditional behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106737/new/

https://reviews.llvm.org/D106737



More information about the cfe-commits mailing list