[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 26 19:12:42 PDT 2021


thakis added inline comments.


================
Comment at: clang/test/LibClang/symbols.test:2
+# Check that there are no unversioned clang symbols in libclang.so
+RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang'
+
----------------
thakis wrote:
> I think it's possible to configure the build to only build a static libclang. This should probably only be done if libclang is built dynamically?
Aha, libclang.so doesn't exist then and then the config.pipefail=False makes things pass then. Subtle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527



More information about the cfe-commits mailing list