[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with minor comment adjustments



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167
+
+  // TODO: Need to support bigger ints like __int128.
+  OS.AddComment("Value");
----------------
I don't think we need a TODO here. If Microsoft ever adds an encoding for large integers, the code change will be elsewhere, and in the process of testing, this size 10 array is bounds checked during the writing process, so we don't need this comment to remind us to change this code.


================
Comment at: llvm/test/DebugInfo/COFF/integer-128.ll:22
+; ASM-NEXT:  .long	4110                            # Type
+; ASM-NEXT:  .byte	0x0a, 0x80, 0xff, 0xff          # Value
+; ASM-NEXT:  .byte	0xff, 0xff, 0xff, 0xff
----------------
(no AI) I see, in the future we should make this use the "streaming" output style so this comes out as `.short .quad` directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105320/new/

https://reviews.llvm.org/D105320