[PATCH] D106715: Thread safety analysis: Drop special block handling

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I think this looks reasonable, but @delesley should weigh in.



================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2415
     bool LocksetInitialized = false;
     SmallVector<CFGBlock *, 8> SpecialBlocks;
     for (CFGBlock::const_pred_iterator PI = CurrBlock->pred_begin(),
----------------
This can be removed now, correct?


================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2448
+        const Stmt *Terminator = (*PI)->getTerminatorStmt();
+        bool IsLoop = Terminator && isa<ContinueStmt>(Terminator);
+        intersectAndWarn(
----------------
clang-tidy got this one right. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106715/new/

https://reviews.llvm.org/D106715