[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 26 07:28:47 PDT 2021


martong added a comment.

In D106642#2900397 <https://reviews.llvm.org/D106642#2900397>, @NoQ wrote:

> Thanks!
>
> You got me thinking whether two symbols can have the same dump. We definitely don't want this to happen but there's also no reason to believe it doesn't, given that this wouldn't affect any actual behavior or any tests. Can we add an assert here that the symbol is always freshly added? In this case we'd at least know when that happens.

Thanks for the review! I've added an assertion to check that a symbol's dump is unique.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106642/new/

https://reviews.llvm.org/D106642



More information about the cfe-commits mailing list