[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

[Amy Kwan via Phabricator via cfe-commits]

amyk added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15111
+    if (IsLE) {
+      Constant *Zero = llvm::Constant::getNullValue(ResTy);
+      SmallVector<int, 16> Consts;
----------------
Maybe we can pull out this line and do the following:
```
Constant *Zero = llvm::Constant::getNullValue(IsLE ? ResTy : AllElts->getType());
```


================
Comment at: clang/test/CodeGen/builtins-ppc-ld-st-rmb.c:1
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: powerpc-registered-target
----------------
nemanjai wrote:
> The test case is quite verbose but the checks were produced by the script so it should be easy to maintain. The reason I added so many checks is that the produce code is very dependent on:
> - endianness
> - CPU
> - the number of bytes (in the store case)
The test is pretty verbose already, but do you think it is necessary to add checks for AIX, or is having just the Linux ones fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106757/new/

https://reviews.llvm.org/D106757