[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

Anastasiia Lukianenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 26 01:54:03 PDT 2021


anastasiia_lukianenko added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:3800
+  FormatStyle Style = getLLVMStyle();
+  Style.BreakBeforeInlineASMColon = true;
   verifyFormat(
----------------
HazardyKnusperkeks wrote:
> I already gave my go in the past, but now I have to wonder, why are you setting this to `true` here? Does this mean before your change clang-format did behave as if the option is `true`? If that's the case please set the default also to `true`. If the old behavior is neither `true` nor `false` we have to find something different.
Old behavior is neither true nor false. As I understand, the behavior was doing break only in case when the string length is longer than column limit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91950/new/

https://reviews.llvm.org/D91950



More information about the cfe-commits mailing list