[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 24 14:07:49 PDT 2021


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

Thanks for the patch. This makes the behavior closer to Linux.cpp . Request changes to clear my queue before a test is added...



================
Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604
+  const bool HasSysRoot = !D.SysRoot.empty();
+  if (HasSysRoot) {
     SmallString<128> P(D.SysRoot);
----------------
To match Linux.cpp, this code block should be unconditional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106737/new/

https://reviews.llvm.org/D106737



More information about the cfe-commits mailing list