[PATCH] D106642: [Analyzer][solver][NFC] print constraints deterministically (ordered by their string representation)

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 23 08:40:28 PDT 2021


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Thanks!

You got me thinking whether two symbols can have the same dump. We definitely don't want this to happen but there's also no reason to believe it doesn't, given that this wouldn't affect any actual behavior or any tests. Can we add an assert here that the symbol is always freshly added? In this case we'd at least know when that happens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106642/new/

https://reviews.llvm.org/D106642



More information about the cfe-commits mailing list