[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 23 06:16:30 PDT 2021


yaxunl added a comment.

In D106315#2898536 <https://reviews.llvm.org/D106315#2898536>, @tra wrote:

> LGTM in general.
>
> One question -- does it have to be a function calling other functions just for the sake of preserving them?
> Can it be a flat array of pointers to the functions you need to keep around?

Yes that's possible. However that would require FE to know these functions and declare them, whereas the current approach leave the concern to the device library.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106315/new/

https://reviews.llvm.org/D106315



More information about the cfe-commits mailing list