[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 23 04:50:46 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D104601#2898095 <https://reviews.llvm.org/D104601#2898095>, @Meinersbur wrote:

> Because of how large the switch construct would have been, I created a new function `types::isDerivedFromC` together with the other functions. These commonly have default-cases so compilers would not warn when `Types.def` is amended, but `isDerivedFromC` can be found between other functions that would need to be updated.

Thank you, I think that turned out cleanly!



================
Comment at: clang/lib/Driver/Types.cpp:173
+  case TY_ObjCXX:
+  case TY_RenderScript:
+  case TY_PP_CHeader:
----------------
Heh, I had to go look this one up. TIL... :-D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104601/new/

https://reviews.llvm.org/D104601



More information about the cfe-commits mailing list