[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

Ben Barham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 17:49:53 PDT 2021


bnbarham added a comment.

In D95159#2897941 <https://reviews.llvm.org/D95159#2897941>, @mibintc wrote:

> Can you suggest how to find the problem?  Thanks a lot.

@mibintc the test is reusing the module cache directory and that's causing some issues between runs, sorry about that. You could add a `rm -rf %t` or `rm -rf %t/mcp` to this test to fix that. Looks like the same issue was run into in https://reviews.llvm.org/D96816#2572589. I'd prefer `clang/test/Index/preamble-reparse-changed-module.m` add the `rm` and another test added for the `LLVM_APPEND_VC_REV=NO` if we want that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95159/new/

https://reviews.llvm.org/D95159



More information about the cfe-commits mailing list