[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 13:55:41 PDT 2021


Anastasia added inline comments.


================
Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7
 
-#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2
+#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0
 #define LANG_VER_OK
----------------
azabaznov wrote:
> As OpenCL C version defaults to 1.2, I think LANG_VER_OK should always be defined now (due to run lines). But OpenCL C 1.2 has never been tested in this test... Is it a mistake in current rest?
Yes this is a typo in the test or something i.e. `LANG_VER_OK` should not be defined for the first run line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106504/new/

https://reviews.llvm.org/D106504



More information about the cfe-commits mailing list