[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

[Necip Fazil Yildiran via Phabricator via cfe-commits]

necipfazil marked an inline comment as done.
necipfazil added inline comments.


================
Comment at: llvm/include/llvm/IR/LLVMContext.h:97
     OB_clang_arc_attachedcall = 6, // "clang.arc.attachedcall"
+    OB_type = 7,                   // "type"
   };
----------------
morehouse wrote:
> necipfazil wrote:
> > morehouse wrote:
> > > Do we need to update `LLVMContext::LLVMContext()`?
> > Operand bundles are originally used as input to lowering in `SelectionDAGBuilder`. Arbitrary operand bundles are not allowed.
> > 
> > To allow `type` operand bundle, we need this change. Please see `llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp` for related changes.
> So why don't you need to update `LLVMContext::LLVMContext()` then?  All other operand bundle types are there.
I added further verifications in LLVMContext::LLVMContext() and some tests for it.

If we requested updates are for somewhere else, could you please provide more details?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105909/new/

https://reviews.llvm.org/D105909