[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 22 12:47:30 PDT 2021
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d669e6666c1: [AIX] Generate large code model relocations when mcmodel=medium on AIX (authored by anjankgk, committed by hubert.reinterpretcast).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106371/new/
https://reviews.llvm.org/D106371
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/mcmodel.c
Index: clang/test/Driver/mcmodel.c
===================================================================
--- clang/test/Driver/mcmodel.c
+++ clang/test/Driver/mcmodel.c
@@ -3,6 +3,8 @@
// RUN: %clang -target x86_64 -### -S -mcmodel=kernel %s 2>&1 | FileCheck --check-prefix=KERNEL %s
// RUN: %clang -target x86_64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=MEDIUM %s
// RUN: %clang -target x86_64 -### -S -mcmodel=large %s 2>&1 | FileCheck --check-prefix=LARGE %s
+// RUN: %clang -target powerpc-unknown-aix -### -S -mcmodel=medium %s 2> %t.log
+// RUN: FileCheck --check-prefix=AIX-MCMEDIUM-OVERRIDE %s < %t.log
// RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s
// TINY: "-mcmodel=tiny"
@@ -10,5 +12,6 @@
// KERNEL: "-mcmodel=kernel"
// MEDIUM: "-mcmodel=medium"
// LARGE: "-mcmodel=large"
+// AIX-MCMEDIUM-OVERRIDE: "-mcmodel=large"
// INVALID: error: invalid argument 'lager' to -mcmodel=
Index: clang/lib/Driver/ToolChains/Clang.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Clang.cpp
+++ clang/lib/Driver/ToolChains/Clang.cpp
@@ -5136,11 +5136,15 @@
if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) {
StringRef CM = A->getValue();
if (CM == "small" || CM == "kernel" || CM == "medium" || CM == "large" ||
- CM == "tiny")
- A->render(Args, CmdArgs);
- else
+ CM == "tiny") {
+ if (Triple.isOSAIX() && CM == "medium")
+ CmdArgs.push_back("-mcmodel=large");
+ else
+ A->render(Args, CmdArgs);
+ } else {
D.Diag(diag::err_drv_invalid_argument_to_option)
<< CM << A->getOption().getName();
+ }
}
if (Arg *A = Args.getLastArg(options::OPT_mtls_size_EQ)) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106371.360934.patch
Type: text/x-patch
Size: 1770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210722/687b440e/attachment.bin>
More information about the cfe-commits
mailing list