[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 09:17:29 PDT 2021


dgoldman added a comment.

Removed the TextMarks file, just need to swap over how the insertions are done



================
Comment at: clang-tools-extra/clangd/TextMarks.h:45
+      : SM(SM), Out(Out) {}
+  void PragmaMark(SourceLocation Loc, StringRef Trivia) override {
+    if (isInsideMainFile(Loc, SM)) {
----------------
sammccall wrote:
> please avoid puttng bodies inline unless trivial or hot
Ah CollectMacros has lots of stuff inline, so  I mirrored that, doesn't look like many other file do that though


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105904/new/

https://reviews.llvm.org/D105904



More information about the cfe-commits mailing list