[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

Kito Cheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 08:45:56 PDT 2021


kito-cheng marked 2 inline comments as done.
kito-cheng added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:460
+
+    addExtension("e");
+  }
----------------
khchen wrote:
> nit: add `break;` to avoid the implicit-fallthrough warning.
Oh, thanks, it seems like more than nit :p


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168



More information about the cfe-commits mailing list