[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 06:50:22 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thank you for the ping, this fell off my radar. LGTM aside from some small nits.



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34
+      template<typename... A,
+        enable_if_t<is_constructible_v<tuple<string,int>,A&&...>,int> = 0>
+      explicit Person(A&&... a) {}
----------------



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:56
+constructor is guarded.
\ No newline at end of file

----------------
Can you add the newline back?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103385/new/

https://reviews.llvm.org/D103385



More information about the cfe-commits mailing list