[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.
Alexander Richardson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 22 05:34:25 PDT 2021
arichardson added inline comments.
================
Comment at: llvm/include/llvm/Support/TargetParser.h:177
StringRef resolveTuneCPUAlias(StringRef TuneCPU, bool IsRV64);
+StringRef computeABIByArch(bool HasD, bool HasE, bool IsRV64);
----------------
Maybe this should be `computeDefaultABIFromArch()`? If `llvm::RISCVISAInfo` can be used here passing `const llvm::RISCVISAInfo&` to the function would also avoid some duplicated lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105555/new/
https://reviews.llvm.org/D105555
More information about the cfe-commits
mailing list