[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

LGTM, just a small question.



================
Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2
+// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL10
 // RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.2 | FileCheck %s --check-prefix=CHECK-SPIR-CL12
 // RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL2.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL20
----------------
Would it be worth having an invocation without any `-cl-std=` and verifying that it produces the same version metadata as CL1.2?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106504/new/

https://reviews.llvm.org/D106504