[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

Fraser Cormack via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 02:10:43 PDT 2021


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10
 /// This file describes the RISC-V instructions from the standard 'V' Vector
 /// extension, version 0.10.
 /// This version is still experimental as the 'V' extension hasn't been
----------------
khchen wrote:
> jacquesguan wrote:
> > khchen wrote:
> > > Do we need to update 0.10 to 1.0-rc?
> > > If the answer is yes, I think maybe we also need to update the clang part (ex. arch parsing, predefine macro) in follow-up patches.
> > > 
> > > 
> > Maybe update it after finishing all changes in 1.0-rc?
> > Maybe update it after finishing all changes in 1.0-rc?
> Yes.
> 
> The other questions like how do you encode `rc1` in `march` or predefined architecture extension macro.
> or maybe we could just use 1.0 directly because v is still an experiential extension.
> 
> @luismarques  @frasercrmck @craig.topper @HsiangKai What do you think?
Maybe we can discuss in the call today, but my initial thoughts would be to just say 1.0 for the reasons you specified.

Perhaps there's already precedent in dealing with release-candidate specs for the base ISA or other extensions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105690/new/

https://reviews.llvm.org/D105690



More information about the cfe-commits mailing list