[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

Simon Tatham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 22 01:36:08 PDT 2021


simon_tatham added a comment.

@lattner, thanks for the help. In this case, the real question is whether there's any use case for `!srcloc` that involves writing it out into a bitcode or IR file and then having a separate instance of clang load it back in again.

I think that no such case can possibly give a useful mapping back to the original source, because IR doesn't serialise the SourceManager that knows how to turn source locations back into a useful error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105491/new/

https://reviews.llvm.org/D105491



More information about the cfe-commits mailing list