[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/tools/libclang/CMakeLists.txt:82
+
+if (LLVM_EXPORTED_SYMBOL_FILE)
+  add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE}
----------------
MaskRay wrote:
> tstellar wrote:
> > MaskRay wrote:
> > > What does this do?
> > > 
> > > A hard-coded list cannot catch up with the real dynamic symbol list. We'll have to parse llvm-readelf --dyn-syms output...
> > Are you saying we should generate the version script using llvm-readelf?
> We may need a test checking that if --version-script is used, there is no `clang_*` symbol which isn't versioned.
> 
> This can be checked by running `llvm-nm -Dj --defined-only` on libclang.so
Oh, you used `local: *`. Then there may need a test that there is no localized `clang_*` symbol.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105527/new/

https://reviews.llvm.org/D105527