[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Qing Shan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 21 04:58:16 PDT 2021


steven.zhang added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-init-variables.cpp:103
+  // Expect no warning given here.
+  Color color;
+  // Expect no warning given here.
----------------
Technical speaking, we should warn about such case, ad the color is undefined now. Can we initialize it to the lowerest value of the enum type ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431



More information about the cfe-commits mailing list