[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

Cullen Rhodes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 21 04:04:21 PDT 2021


c-rhodes added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:8673
 
+/// getSVETypeSize - Return SVE vector or perdicate register size.
+static uint64_t getSVETypeSize(ASTContext &Context, const BuiltinType *Ty) {
----------------
s/perdicate/predicate


================
Comment at: clang/test/SemaCXX/aarch64-sve-lax-vector-conversions.cpp:13-14
 typedef svfloat32_t sve_fixed_float32_t SVE_FIXED_ATTR;
 typedef svint32_t sve_fixed_int32_t SVE_FIXED_ATTR;
+typedef svbool_t sve_fixed_bool_t SVE_FIXED_ATTR;
 typedef float gnu_fixed_float32_t GNU_FIXED_ATTR;
----------------
unused?


================
Comment at: clang/test/SemaCXX/aarch64-sve-lax-vector-conversions.cpp:17
 typedef int gnu_fixed_int32_t GNU_FIXED_ATTR;
+typedef int8_t gnu_fixed_bool_t GNU_BOOL_FIXED_ATTR;
 
----------------
also unused?


================
Comment at: clang/test/SemaCXX/attr-arm-sve-vector-bits.cpp:32
+
+// Test implicit casts between VLA and VLS perdicates
+svbool_t to_svbool_t(fixed_bool_t x) { return x; }
----------------
s/perdicates/predicates


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106333/new/

https://reviews.llvm.org/D106333



More information about the cfe-commits mailing list