[PATCH] D105703: [hwasan] Use stack safety analysis.

[Florian Mayer via Phabricator via cfe-commits]

fmayer added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406
+    // architecture that doesn't allow stack tagging we will still load the
+    // analysis.
+    // This is so we don't need to plumb TargetTriple all the way to here.
----------------
vitalybuka wrote:
> I like this even less than "plumbing",  if you need shouldUseStackSafetyAnalysis please just pass Triple as in earlier versions.
> 
> Why do you need to avoid loading analysis? Revert does not explain what is broken.
I am still looking at the breakage. But if  you looked at the logic before, there was the case DisableOptimization BUT ClUseStackAnalysis being explicitly set, which made us try to getAnalysis without having required it here.

I also like the plumbing more than this, but changed to this to see what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703