[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 20 17:36:38 PDT 2021


hubert.reinterpretcast added a comment.

LGTM with minor nit; thanks.



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5140
+        A->render(Args, CmdArgs);
+    } else
       D.Diag(diag::err_drv_invalid_argument_to_option)
----------------
Add braces to the `else` block when adding braces to the `if` block: The coding guidelines have been updated for some time to discourage mixed bracing on if/else chains (see example
```
// Use braces for the `if` block to keep it uniform with the else block.
```
).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106371/new/

https://reviews.llvm.org/D106371



More information about the cfe-commits mailing list